Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throttle messages from target plugin #6

Merged
merged 3 commits into from
Oct 7, 2020
Merged

throttle messages from target plugin #6

merged 3 commits into from
Oct 7, 2020

Conversation

JStech
Copy link
Contributor

@JStech JStech commented Jun 10, 2020

Adding some throttling. Probably going to add more still.

@JStech JStech changed the title WIP: throttle messages throttle messages from target plugin Aug 21, 2020
@JStech
Copy link
Contributor Author

JStech commented Aug 21, 2020

Since the target plugin object gets recreated every time an image arrives ( #14 ), some of these messages get printed rather often, so I added throttling to them.

tylerjw
tylerjw approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throttling error messages is a nice thing to do if they can fill up logs

@tylerjw tylerjw merged commit 6c9044d into moveit:master Oct 7, 2020
@prasuchit prasuchit mentioned this pull request Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjw tylerjw tylerjw approved these changes

@RoboticsYY RoboticsYY Awaiting requested review from RoboticsYY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JStech @tylerjw